i18n: fix example category translations across languages#1090
i18n: fix example category translations across languages#1090rakesh2OO5 wants to merge 2 commits into
Conversation
|
Hi @limzykenneth 👋 |
|
Some questions. What is the source of the translation? Especially for the updates? What is your understanding of the original issue? |
|
Hi @limzykenneth, thanks for taking a look and for the questions — happy to clarify! Source of the translations : About the updates My understanding of the original issue (#283) If you’d prefer a different translation style or have a recommended source/guide for localization in this project, I’d be very happy to align with it and update the PR accordingly. Thanks again for your time and guidance! |
|
The reason I'm asking is that there are many translation changes that are not missing originally but they are changed, which is not what the original issue is about. Some of these translation changes also does not make sense since they don't change the meaning at all. I'm also not happy to accept any machine translation without native language user's input. |
|
Hi @limzykenneth, thank you for clarifying — I appreciate you pointing this out. You’re absolutely right about the scope. My intent was to ensure consistency across locales, but I understand now that this went beyond the original goal of addressing missing category keys only. I can revise this PR to: For the translated labels I added, I agree that native-language validation is important. If you’d prefer, I can either remove those or flag them for review by native contributors instead of including them here. Please let me know which direction you’d prefer, and I’ll update the PR accordingly. Thanks for taking the time to review and guide me on this . |
|
Hi @rakesh2OO5, I went through this PR, checked the current state of all five locale files on main, looked at the component rendering the Examples page, and tested locally. Here is what I found. Here is the current state of exampleCategories across all five locale files on main: English: all 16 categories present Korean and Chinese already have everything they need. The gap is Spanish and Hindi. Looking at how the Examples page actually works, the component at src/layouts/ExamplesLayout.astro is already wired to the translation system. It calls the translation function for every category heading like this: name: t("exampleCategories", category) As @stalgiag noted back in April 2024, the keys already exist in en.yaml https://github.com/processing/p5.js-website/blob/main/src/content/ui/en.yaml#L97. The infrastructure is already in place. The reason Spanish and Hindi users see English category headings is simply because es.yaml and hi.yaml are missing 15 entries each Looking at the files changed, there are a few issues worth flagging. The entry for Listing Data with Arrays uses lowercase with instead of the capital W in en.yaml, which means that category will still fall back to English. In hi.yaml the duplicate Featured key changes the meaning from प्रमुख to विशेष without native speaker validation. And in zh-Hans.yaml, working translations were replaced with alternatives that carry the same meaning, with duplicate keys introduced, which is the pattern @limzykenneth pointed to in his review. Also, while the 15 missing entries were added to es.yaml and hi.yaml, the source and quality of those translations were questioned by @limzykenneth and remain unresolved. Given the open questions around translation quality and the technical issues in the diff, this PR is not ready to merge in its current state. |





Summary
Fixes missing and inconsistent translations for Example Categories across multiple languages.
What was changed
Verification
fixes issue #283